Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roles in tree-table to pass ARIA1.1 check #1549

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

cwolf10
Copy link
Collaborator

@cwolf10 cwolf10 commented Oct 17, 2024

Description

Update roles in tree-table to pass ARIA 1.1 check performed by AMP. If testing standard updates to ARIA 1.2 or greater then posinset is a valid property of the row role.

Motivation and Context

Resolves #1160

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Passing AMP test:
image

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

@cwolf10 cwolf10 added the bugfix Something isn't working label Oct 17, 2024
@cwolf10 cwolf10 linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-17 17:48 UTC

@yerramshilpa yerramshilpa merged commit 54cc8e7 into master Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMP issue with Tree-Table HTML <tr> element
2 participants