Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make optional params for SearchSettings optional #756

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

jesseboydgsa
Copy link
Contributor

fix SearchSettings fields to be correctly marked as optional to allow for accurate type checking

Description

make SearchSettings type safe

Motivation and Context

we have turned on typechecking and having all fields required breaks our code and is unnecessary when using default values

Type of Change (Select One and Apply Github Label)

  • [x ] Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • [x ] Chrome
  • Firefox
  • Safari

Checklist:

@Bibek-Regmi Bibek-Regmi merged commit 7125006 into master Jul 20, 2021
@yerramshilpa yerramshilpa deleted the jesseboydgsa-patch-searchSettings branch October 16, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants