Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ngOnChange in layout #764

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Conversation

Bibek-Regmi
Copy link
Contributor

Description

Update layout to remove ngOnChanges. It automatically updated sort value anytime configs changed and made api call with updated value. The drawback here is that any config changes to layout results in an api call. Instead, the recommendation, when users want to update sort values outside of init, is to manually call updateSearchResultsModel with the given sort value.

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

@Bibek-Regmi Bibek-Regmi reopened this Jul 27, 2021
@Bibek-Regmi Bibek-Regmi merged commit e526ed2 into master Jul 28, 2021
@yerramshilpa yerramshilpa deleted the remove-ng-onchange-on-layout branch October 16, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants