Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat label inputs as base html for checkbox and radios #869

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Bibek-Regmi
Copy link
Contributor

Description

Update how we add labels to templates for checkboxes and radios. Use innerHTML rather than string interpolation binding to allow custom template for labels - such as anchor tags

Motivation and Context

#868

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

@Bibek-Regmi Bibek-Regmi merged commit befc3cd into master Nov 15, 2021
@yerramshilpa yerramshilpa deleted the git-868-allow-base-html-for-checkbox-labels branch October 16, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants