Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand scope of CLI tests #133

Open
laurencejackson opened this issue Nov 4, 2021 · 3 comments
Open

Expand scope of CLI tests #133

laurencejackson opened this issue Nov 4, 2021 · 3 comments
Labels
good first issue Good for newcomers tests Unit tests

Comments

@laurencejackson
Copy link
Collaborator

We should add more steps to .github/workflows/cli-test.yml so that every Hazen task is tested and the outputs checked. Currently, we only check the CLI returns an exit code 0.

Good first issue to get people started with the github actions.

@laurencejackson laurencejackson added the good first issue Good for newcomers label Nov 4, 2021
@tomaroberts tomaroberts self-assigned this Nov 8, 2021
@laurencejackson laurencejackson added this to the 0.5.0 milestone Dec 10, 2021
@tomaroberts tomaroberts modified the milestones: 0.5.0, 0.5.1 Dec 10, 2021
@tomaroberts
Copy link
Collaborator

Think we decided this is lower priority, so going to remove from milestones for now.

@tomaroberts tomaroberts removed this from the 0.5.2 milestone Dec 21, 2021
@laurencejackson
Copy link
Collaborator Author

Think we decided this is lower priority, so going to remove from milestones for now.

I thought this should have fairly high priority? It should be straightforward to add and will catch any function breaking bugs that aren't caught by the unit tests before pushing to production branches

@tomaroberts
Copy link
Collaborator

Ahh, sorry, got it confused with #134. We can keep high priority.

@tomaroberts tomaroberts added the tests Unit tests label Jun 30, 2023
@tomaroberts tomaroberts removed their assignment Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests Unit tests
Projects
None yet
Development

No branches or pull requests

2 participants