Improve test coverage

[laurencejackson]

Our test coverage is currently at around 71% which could be better. The line numbers in the table below show which lines are currently not run during any of the tests. We should expand our existing tests or (if necessary) write new ones to cover these lines.

This is another good issue to get people familiar with the automatic testing system.

File	Stmts	Miss	Cover	Missing
hazenlib
init.py	132	67	49%	128, 132, 142, 147, 183–186, 191–196, 208, 211–218, 237–239, 256–258, 276–278, 286, 290–293, 297, 312–319, 324–360
exceptions.py	21	4	81%	17–21
ghosting.py	156	50	68%	24, 89–90, 94, 104–105, 132–133, 142–143, 198–226, 233–251, 255
relaxometry.py	308	90	71%	238–256, 630, 689–691, 745, 793–815, 833–848, 1168–1171, 1180–1183, 1195–1208, 1211–1216, 1228–1258
slice_position.py	109	20	82%	72–73, 98, 182, 189–202, 210, 218–219, 230
slice_width.py	287	45	84%	23, 26, 30, 34–39, 105, 275, 280–281, 287, 292, 355–356, 591–630, 666–669, 672–675
snr.py	138	50	64%	39–44, 72, 147–157, 181–191, 195–199, 231–242, 247–255, 283–294, 318, 326–328, 331
spatial_resolution.py	290	99	66%	84–142, 156, 238, 278–285, 313, 443–476, 497–514
tools.py	66	9	86%	42–49, 88, 97, 112–113
uniformity.py	79	22	72%	68–69, 76, 110–122, 134–136, 139, 143–146, 154
TOTAL	1586	456	71%

[Lucrezia-Cester]

Hi @tomaroberts ! I assigned myself this issue #90 (add tests for init in hazenlib). Since you have this issue, where hazenlib init is included, I was wondering if you were ok with me writing the tests for the init module.

[tomaroberts]

Discussed tests_snr.py with Laurence. Current tests are integration tests. Will be better to have specific unit tests for each function in snr.py.

[tomaroberts]

Hi @tomaroberts ! I assigned myself this issue #90 (add tests for init in hazenlib). Since you have this issue, where hazenlib init is included, I was wondering if you were ok with me writing the tests for the init module.

@Lucrezia-Cester – go for it. I'm going to start with tests_snr.py and then move onto others after that.

[sophie22]

more recent test coverage stats: from version v1.3.1

File	Stmts	Miss	Cover	Missing
hazenlib
ACRObject.py	107	11	90%	74, 77–79, 84–87, 125, 168–169
HazenTask.py	28	3	89%	41–43
\_\_init\_\_.py	56	15	73%	166, 197–200, 202–206, 208–210, 225–230, 234
exceptions.py	21	5	76%	17–21, 38
utils.py	189	43	77%	61, 65, 75, 80, 117, 124–129, 140, 143–150, 170–172, 190–192, 211–213, 222, 227, 233, 284, 287, 295–300, 303, 346, 355, 371
hazenlib/tasks
acr_geometric_accuracy.py	119	62	48%	42–86, 96–121, 134–168
acr_ghosting.py	107	42	61%	35–51, 77–79, 109–111, 145–187
acr_slice_position.py	136	48	65%	47–68, 194–241
acr_slice_thickness.py	136	60	56%	34–53, 162–224
acr_snr.py	136	58	57%	46, 51–92, 102, 172–182, 216–231, 264–281
acr_spatial_resolution.py	206	68	67%	59–86, 131, 174, 187–196, 278–330
acr_uniformity.py	81	32	60%	38–56, 112–138
ghosting.py	151	51	66%	19–36, 51, 113–114, 118, 128–129, 155–157, 174–176, 222–259
relaxometry.py	290	89	69%	207–208, 210, 221–224, 230–236, 268–312, 353, 387–405, 580, 626–628, 695, 769–791, 809–824
slice_position.py	124	40	68%	26, 31–62, 114–115, 141, 221, 229–247
slice_width.py	350	52	85%	36–38, 42, 107, 166–187, 441, 446–447, 453, 458, 516–517, 767–809
snr.py	168	67	60%	61, 78–83, 179–197, 212–221, 239–249, 276–286, 291–301, 332–346, 351–359, 388–402
snr_map.py	107	1	99%	152
spatial_resolution.py	248	44	82%	41–43, 47, 68, 153, 212, 338–375
uniformity.py	79	19	76%	47–49, 53, 95–96, 103, 137–152
TOTAL	2864	810	72%