Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClosestPoint() implementation for meshes #416

Open
iltabe opened this issue Jun 1, 2023 Discussed in #415 · 6 comments · Fixed by mulestudio/G-Shark#1 · May be fixed by #420
Open

ClosestPoint() implementation for meshes #416

iltabe opened this issue Jun 1, 2023 Discussed in #415 · 6 comments · Fixed by mulestudio/G-Shark#1 · May be fixed by #420
Assignees
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.

Comments

@iltabe
Copy link

iltabe commented Jun 1, 2023

Discussed in #415

Originally posted by iltabe May 30, 2023
Hi guys!

I know some of you for different reasons! Ciao!

For a client I'm building an algorithm that requires some geometrical operations. I've looked into G-Shark and started to use it. It looks promising and does almost everything I need (basic vector, point, plane stuff).
Thanks guys for having give birth to this nice project!

The only thing I miss is a mesh.ClosestPoint(Point3 pt) method... Is it in the todo list by any luck?
Thanks!
Gianluca

It would be nice to implement some functionality for meshes, especially myMesh.ClosestPoint(Point3 test_point).
The behaviour I expect is to get back from the function the real closest point:

  1. on a mesh vertex, if the mesh vertex is the closest point to the test point
  2. on a mesh face boundary (edge) if that is the closest point to the test point
  3. a point inside a mesh face if the length of the line perpendicular to the face (and passing per test_point) is shorter to any other line connecting test_point to the mesh.

Long story short: the closest point! :)

@iltabe
Copy link
Author

iltabe commented Jul 5, 2023

Hi there!

We found a bit of internal resources to work on this, so we started a first implementation.
We will open a PR in the next few days/weeks.
Thanks!

@d3ssy
Copy link
Collaborator

d3ssy commented Jul 5, 2023 via email

@iltabe
Copy link
Author

iltabe commented Jul 26, 2023

Ciao @d3ssy,
The PR regarding mesh closest point is out. Who is the best person to be tagged as reviewer?
Thanks!

@d3ssy
Copy link
Collaborator

d3ssy commented Jul 26, 2023

I'll review later today, cheers!

@iltabe
Copy link
Author

iltabe commented Jul 26, 2023 via email

@d3ssy
Copy link
Collaborator

d3ssy commented Aug 7, 2023

@iltabe Review done! Apologies for the delay. Please reach out if you need any help or further info!

@sonomirco sonomirco added enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning. labels Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants