Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/guma/point at chord length #370

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Conversation

d3ssy
Copy link
Collaborator

@d3ssy d3ssy commented Sep 20, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

  • Adds evaluation of a curve at a given chord length.
  • Adds divide curve by curve length returning a series of parameters along the curve.
  • Renames test data in NurbsCurveCollection.

NOTE: Methods return a parameter/list of parameters rather than points. The parameters can then be used to evaluate a point on the same input curve if needed.

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Closes #212

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@d3ssy d3ssy added enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. labels Sep 20, 2021
@d3ssy d3ssy merged commit 0a6f0d3 into develop Sep 20, 2021
@d3ssy d3ssy self-assigned this Sep 20, 2021
@sonomirco sonomirco deleted the dev/guma/point-at-chord-length branch October 6, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PointAt chord length
2 participants