Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extrude and Sweep surface #371

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Extrude and Sweep surface #371

merged 5 commits into from
Oct 6, 2021

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR adds the last 2 methods to construct surfaces, extrusion following a direction, and sweep with one rail.

Related Tickets & Documents

This PR closes #115
This PR closes #201

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. label Oct 3, 2021
@sonomirco sonomirco self-assigned this Oct 3, 2021
@sonomirco sonomirco merged commit 0616db2 into develop Oct 6, 2021
@sonomirco sonomirco deleted the dev/mibi/extrude-sweep-surface branch October 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3ssy d3ssy d3ssy left review comments

@philipblaquiere philipblaquiere Awaiting requested review from philipblaquiere

@cesarecaoduro cesarecaoduro Awaiting requested review from cesarecaoduro

Assignees

@sonomirco sonomirco

Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateSweepSurface CreateExtrudeSurface
2 participants
@sonomirco @d3ssy