Fix plane to plane transform and test. #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonomirco
reviewed
Oct 19, 2021
| var mapATransposed = mapA.Transpose(); | ||
| Matrix result = translation1 * mapB * mapATransposed * translationA; | ||
| var xForm = new Transform(); | ||
| xForm.Clear(); |
There was a problem hiding this comment.
we should have a constructor from a matrix :)
There was a problem hiding this comment.
I was actually going to add an implicit operator to convert to matrix from plane and transform, but I think we may as well refactor transform specifically into a 4x4 matrix with individual properties for each value as we've always discussed and keep it in a separate issue.
sonomirco
reviewed
Oct 19, 2021
src/GShark/Core/Transform.cs
Outdated
| // Mapping x0 to x1, y0 to y1, z0 to z1 | ||
| Transform map = map0 * map1; | ||
| return translation1 * map * translation0; | ||
| var translation1 = new Matrix(); |
There was a problem hiding this comment.
translation1 and translationA, could be translationPt0ToOrigin and translationOriginToPt1?
I am fine also with translation1 and translationA, but why 1 and A? ahahh
sonomirco
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Rewrites plane to plane transform logic and test with arbitrary planes.
Related Tickets & Documents
Fixes #372
Added tests?
Added to documentation?