Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and prevent NPE #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MCTBL
Copy link

@MCTBL MCTBL commented Oct 4, 2024

fixed: 588

@MCTBL MCTBL requested review from OneEyeMaker, slprime and a team October 4, 2024 07:17
@slprime
Copy link
Member

slprime commented Oct 4, 2024

How to reproduce this bug?

@MCTBL
Copy link
Author

MCTBL commented Oct 4, 2024

he siad if there has any thing is acrane recipe will cause this bug, such as Proven Frame.

  1. If you order something that use acrane recipe and there has something lacking
  2. If you order some acrane thing and lacking some input

then trying click the cancel button with pressing shift.

  1. try to order some Air Crystal Cluster and Air Shard is not enough, then shift click cancel
out2.mp4
  1. try to order some Frame Housing and some thing is not enough. But there has Proven Frame recipe, and shift click cancel
out.mp4

@MCTBL
Copy link
Author

MCTBL commented Oct 4, 2024

this bug is cause by the function that shift click cancel button will add the lacking input into NEI bookmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

something wrong makes bugs with NPE
2 participants