Initial support for channels on EnderFluidConduits #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty basic support for channels. There's plenty of room for optimizations in the network logic.
Glease
reviewed
Dec 10, 2020
src/main/java/crazypants/enderio/conduit/liquid/EnderLiquidConduit.java
Outdated
Show resolved
Hide resolved
Glease
approved these changes
Dec 11, 2020
|
Resolve merge conflict please. |
* Fix missing } after merge
|
Resolved the merge conflict and fixed the references. Now we just need to fix the GUI which became too cramped with both the channel and RR button. |
|
I have now fixed the GUI of the fluid conduit as well, based how it's done for item conduits. It should be ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty basic support for channels on ender fluid conduits. It mainly copies item conduits for gui and rendering and does the most basic check possible to match source and target before checking target filters or target acceptance.