Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement advanced ender fluid conduits #33

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Implement advanced ender fluid conduits #33

merged 1 commit into from
Oct 17, 2021

Conversation

D-Cysteine
Copy link

Adaptation of code in:

Here's what I changed from that PR:

  • Refactored EnderLiquidConduit logic into an abstract base class, allowing the new conduit to extend the base class and get most of the functionality "for free"
    • This allows channels, filtering, round-robin, etc. to work for the new conduit
  • It looked like the item icon was wrong / different from the ender one, so I replaced it with a copy of the conduit core icon (it looks like the other fluid conduits also use a copy of the conduit core icon for this)
  • Slightly tweaked the recipe to be symmetrical. Though we may want to replace the recipe anyway?
  • Renamed "EnderAdvanced" to "AdvancedEnder" in code as that is more consistent with the naming used by other conduits
  • Added placeholder entries in other language files (using the English string for now)
  • Rebased to include latest upstream changes

Co-Authored-By: Prometheus0000 [email protected]

Adaptation of code in:
 * #23

Co-Authored-By: Prometheus0000 <[email protected]>
@Dream-Master
Copy link
Member

work for me in sp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants