Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moving around buttons in Big Advanced Item Filter #61

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix: moving around buttons in Big Advanced Item Filter #61

merged 2 commits into from
Apr 5, 2022

Conversation

theyugin
Copy link

@theyugin theyugin commented Apr 4, 2022

Closes GTNewHorizons/GT-New-Horizons-Modpack#10098

Rearranged buttons in Big Advanced Item Filter to make Ignore/Match Meta Data and Sticky Mode Enabled/Disabled buttons not overlap with each other.
Before:
image
After:
image

Glease
Glease reviewed Apr 4, 2022
View reviewed changes
Copy link

@Glease Glease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather move the sticky mode button instead. It's making the extraction mode config view rather weird.
image

@theyugin
Copy link
Author

theyugin commented Apr 5, 2022

That is true, made some moving around.
image
image

@theyugin theyugin requested a review from Glease April 5, 2022 00:07
@Dream-Master Dream-Master merged commit f4f2b85 into GTNewHorizons:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glease Glease Glease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnderIO Big Advanced Item Filter "Ignore Meta Data" and "Sticky Mode" buttons overlap
3 participants
@theyugin @Glease @Dream-Master