Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedupAnimations breaks animations for blocks that render with drawCrossedSquares #264

Open
connor135246 opened this issue Oct 15, 2023 · 0 comments
Open

speedupAnimations breaks animations for blocks that render with drawCrossedSquares #264

connor135246 opened this issue Oct 15, 2023 · 0 comments

Comments

@connor135246
Copy link

Blocks that use animated textures and render as crossed squares (small flowers, saplings, etc) won't be animated if speedupAnimations is enabled.

Steps to reproduce:

  1. Ensure speedupAnimations is enabled.
  2. Add this resource pack: animated_crossed_squares_pack.zip. This makes poppies have an animated texture.
  3. Place a poppy in the world.
  4. Remove any poppies from your inventory so that the animation won't be updated by the item.
    -> The poppy block will stop being animated.

I think the solution is that the MixinRenderBlocks file should inject a texture update into the drawCrossedSquares method.
@connor135246 connor135246 mentioned this issue Oct 15, 2023
Open
makamys added a commit to GTNewHorizons/Angelica that referenced this issue Jan 21, 2024
@makamys
Mark animations of crossed squares
5b705d2 
Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#264
Fixes Campfire Backport campfire flames not animating (but the embers and the
mixed NEI flames are still broken)
mitchej123 pushed a commit to GTNewHorizons/Angelica that referenced this issue Jan 21, 2024
@makamys
Fix campfire backport animations (#224)
3755e25 
* Mark animations of crossed squares

Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#264
Fixes Campfire Backport campfire flames not animating (but the embers and the
mixed NEI flames are still broken)

* Add Campfire Backport compatibility to animation speedup

Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#204
Fixes embers and NEI mixed flames not animating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@connor135246