Add JEI-style item presence overlay when hovering over the ? button #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicates which items are missing and which ones are present in your inventory with small X/checkmark symbols when you hover over the ? button in a recipe gui.
mitchej123
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicates which items are missing and which ones are present in your inventory with small X/checkmark symbols when you hover over the ? button in a recipe gui. I decided on icon overlays rather than color overlays because it should make sure there are no problems with transparency and it'll be clearer for colorblind people. There's a toggle switch in the settings to turn it off.
I've tested this on a dev client, dev server+client, dev client with ic2+gt, local gtnh 2.1.0.6b instance.
Screenshots
As you can see on the last screenshot, the arcane workbench has a minor visual glitch where the crosses appear over aspects because they count as ingredient ItemStacks in the recipe handler, there might be similar edge cases in other handlers but as it doesn't affect the behavior of recipe filling I don't think it matters too much.
It also obviously doesn't work for most GregTech machine recipes, as they don't have an overlay handler = no [?] button . If you have an idea for a better UI for this, I'm happy to try to implement it.