Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsibleitems #506

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

slprime
Copy link
Member

@slprime slprime commented Jul 13, 2024

Collapsible Items

Default collapsed expanded
image image image

Toggle group state (alt+click):

image

Toggle all groups:

image

Settings (NEI Config - Inventory - Collapsible Items):

image

Dev details:

Modpack groups are in config/NEI/collapsibleitems.cfg
My groups for GTNH: collapsibleitems.zip

expanded collapsed
image image

The rules that I tried to adhere to when creating groups:

    • objects of the same type but different colors (example: glass)
    • items of the same tier but from different materials (example: drawers)
    • association by topic. not advisable. rarely used (example: flower)

Presets Refactoring

Remove button from this place

before after
image image

New Presets Settings (NEI Config - World - Presets List):

image
image

Mode:

  1. Hide - Hide items in right panel
  2. Remove - Hide items in right panel and it recipes in Gui Recipe
  3. Group - Create custom collapsible items group

@Caedis
Copy link
Member

Caedis commented Jul 13, 2024

Great job

Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be .tip

@Caedis
Copy link
Member

Caedis commented Jul 13, 2024

Could a config option be added so you can hold alt over a group to expand it instead of alt + click?

@slprime
Copy link
Member Author

slprime commented Jul 13, 2024

Could a config option be added so you can hold alt over a group to expand it instead of alt + click?

not sure. best way was be add it in keybinding settings, but whey dont have posibility added mouse click

@Dream-Master Dream-Master requested a review from a team July 13, 2024 12:04
@Caedis
Copy link
Member

Caedis commented Jul 13, 2024

@Dream-Master once this is merged, can you add the included config file to the pack configs?
https://github.com/user-attachments/files/16201214/collapsibleitems.zip

Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, runs without issue in the pack and the included config is great.

I do want 1 more person to review to make sure I didnt miss anything else besides the lang issue.

@Dream-Master
Copy link
Member

@Caedis are this is a new config file ? better make a pr in modpack pr so link it to this pr. Maybe i forgot this file when pr is merged.

@Caedis
Copy link
Member

Caedis commented Jul 13, 2024

done

@PlayfulPiano
Copy link

bless you

@slprime slprime mentioned this pull request Jul 23, 2024
@Dream-Master
Copy link
Member

works for me ingame.

@Dream-Master Dream-Master merged commit d61a545 into GTNewHorizons:master Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants