Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes & changes #523

Merged
merged 9 commits into from
Sep 1, 2024
Merged

Small fixes & changes #523

merged 9 commits into from
Sep 1, 2024

Conversation

slprime
Copy link
Member

@slprime slprime commented Aug 31, 2024

No description provided.

@slprime slprime requested a review from a team August 31, 2024 21:47
@slprime slprime changed the title Small fixes Small fixes & changes Aug 31, 2024
@slprime
Copy link
Member Author

slprime commented Sep 1, 2024 •
edited
Loading

fix issue: #524

OneEyeMaker
OneEyeMaker requested changes Sep 1, 2024
View reviewed changes
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup overall.
Please, list and explain all your changes for clarification (movement of some method calls is unclear).

src/main/java/codechicken/nei/ClientHandler.java Show resolved Hide resolved
src/main/java/codechicken/nei/recipe/GuiOverlayButton.java Outdated Show resolved Hide resolved
@Dream-Master Dream-Master requested review from OneEyeMaker and a team September 1, 2024 19:34
@slprime
Copy link
Member Author

slprime commented Sep 1, 2024 •
edited
Loading

Nice cleanup overall. Please, list and explain all your changes for clarification (movement of some method calls is unclear).

  1. Fixed display of crosses/check marks in bookmarks
    image
  2. Hide hotkeys if it not set
  3. Search items by original name and renamed name (Ex. show all "ME Covered Cable - White")
    image
  4. Fix shift + click in subsets
    image
  5. Add ability extend recipe overlay states. (ex. simplified adding crafting icon)
    image

P.S.
I rewrote getKeyName to simplify the way it derives neiKeyBindings. And correctly it should be in utilities, not in the config

OneEyeMaker
OneEyeMaker approved these changes Sep 1, 2024
View reviewed changes
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@boubou19 boubou19 merged commit 65652e5 into GTNewHorizons:master Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneEyeMaker OneEyeMaker OneEyeMaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slprime @OneEyeMaker @boubou19