Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix Item Render & GuiRecipeHandler #528

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

slprime
Copy link
Member

@slprime slprime commented Sep 11, 2024

Render:

Before After
Screenshot 2024-09-11 163344 Screenshot 2024-09-11 165229

Before:

GT_.New.Horizons.2.7.0.2024-09-11.19-54-43.mp4

I hope I fixed all similar problems: GTNewHorizons/GT-New-Horizons-Modpack#15816

Catalyst font size:

Before After
Screenshot 2024-09-11 122814 image

P.S. If someone knows how to redefine method net.minecraft.client.gui.GuiIngame.renderInventorySlot(IIIL)V by using org.objectweb.asm then it would be possible to correct such error (slot 2,7-9)

Screenshot 2024-09-11 181934

@Dream-Master Dream-Master requested a review from a team September 12, 2024 08:10
@Cardinalstars
Copy link

Cardinalstars commented Sep 15, 2024

I'm not a rendering wizard, but the changes do seem clean. I'll just comment this for now until someone who is a little more experienced in MC rendering gives this one a go, but I can say the text stuff is quite nice.

Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants