Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor performance during clean build #49

Open
makamys opened this issue Oct 20, 2023 · 0 comments
Open

Poor performance during clean build #49

makamys opened this issue Oct 20, 2023 · 0 comments

Comments

@makamys
Copy link
Collaborator

makamys commented Oct 20, 2023

I recently updated UniMixins to use RFG instead of FG, and noticed greatly increased build times during clean builds of the mod (4m -> 8m on Github Actions using no cache) along with increased memory and disk usage. Some more results from my own machine are available here, but to sum it up:

Plugin Time RAM Disk
FG 01:39 1.1 GB 72 MB
RFG 08:58 2.62 GB 881 MB

As for why it happens, there are two main inefficiencies that I can see:

  1. RFG will recompile Minecraft even if the mod doesn't use ATs, which is completely unnecessary and costs a bunch of time and disk space.
  2. RFG puts a copy of the native libraries (23 MB for LWJGL2) in the run directory of each mod, instead of using a shared copy like FG.
makamys added a commit to LegacyModdingMC/UniMixins that referenced this issue Oct 21, 2023
@makamys
Reject RFG, return to FG
28b93dd 
RFG's performance is unsuitable for this project, see
GTNewHorizons/RetroFuturaGradle#49

Reverts the following commits:

ba1f02d Begin RFG move. Common module compiles
b589106 Mixin module works now I think
46a5c6d Use VERSION tag in Mixin module
2409b24 Mixingasm seems to work now
f0b355c Sources jar get
23e833f Remove redundant calls
2e78938 Update gradle in hopes that it will magically fix all my problems
80e0723 Port all the modules
28e98d5 Port All module (not the same thing)
3a09260 Fix common module build failing
1088934 Get rid of bloat from buildscript template
bff36c3 Porting is done now maybe
27e3058 Fix what I broke
bbc0b48 zulu?
9b4bde7 I guess I need Java 17 too
c3af516 RFG needs alot of ram apparently

But keeps these:

9152c1a Don't build alternate flavors by default
24f6c06 Move compat module's MixinExtras temp jar to temp dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@makamys