-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Liquefaction Focus #72
base: master
Are you sure you want to change the base?
Conversation
DrParadox7
commented
Jul 10, 2024
- Fixes [1.5.1.2] dupe thaumic horizons GT-New-Horizons-Modpack#1930
- Minor Cleanup
Fixes Hoborific#4 plus some cleanup
Have you tested this locally and on a server? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Have you tested this locally and on a server?"
My statement still stands, this is highly important especially in this specific case.
@Alastors @DrParadox7 i make a pre tag so whe can test it on Zeta |
I wouldn't recommend that. Until we know he has tested it, I wouldn't do anything of the sort. That's like literally the bare minimum in cases like these where some funky shit is going down clientside. |
I’m removing my requests for changes but can we get a comment from @DrParadox7 |
ThaumicHorizons.proxy | ||
.smeltFX(ent.posX - 0.5, ent.posY, ent.posZ - 0.5, player.worldObj, 5 * quantity, false); | ||
|
||
resultItem.stackSize = quantity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sets the output item amount equal to the input item and ignores the recipe output amount. The correct amount would be inputAmount * recipeOutputAmount
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, just don't want to be the one working it.
That's how it previously worked and making it adhere to that sound logic requires a mini rework.
The scope of this PR was just having it not break recipes