Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Liquefaction Focus #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

DrParadox7
Copy link

Fixes Hoborific#4 plus some cleanup
@Alastors
Copy link
Member

Have you tested this locally and on a server?

@Dream-Master Dream-Master requested a review from a team July 14, 2024 02:20
Copy link
Member

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Have you tested this locally and on a server?"

My statement still stands, this is highly important especially in this specific case.

@Dream-Master
Copy link
Member

@Alastors @DrParadox7 i make a pre tag so whe can test it on Zeta

@Alastors
Copy link
Member

Alastors commented Jul 14, 2024

I wouldn't recommend that.

Until we know he has tested it, I wouldn't do anything of the sort.

That's like literally the bare minimum in cases like these where some funky shit is going down clientside.

@Alastors
Copy link
Member

I’m removing my requests for changes but can we get a comment from @DrParadox7

@Alastors Alastors dismissed their stale review August 23, 2024 20:24

Tested by others, not in depth though

ThaumicHorizons.proxy
.smeltFX(ent.posX - 0.5, ent.posY, ent.posZ - 0.5, player.worldObj, 5 * quantity, false);

resultItem.stackSize = quantity;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets the output item amount equal to the input item and ignores the recipe output amount. The correct amount would be inputAmount * recipeOutputAmount.

Copy link
Author

@DrParadox7 DrParadox7 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, just don't want to be the one working it.
That's how it previously worked and making it adhere to that sound logic requires a mini rework.

The scope of this PR was just having it not break recipes

@Dream-Master
Copy link
Member

@DrParadox7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5.1.2] dupe thaumic horizons
4 participants