Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pubkey check #83

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Add pubkey check #83

merged 7 commits into from
Oct 15, 2024

Conversation

anhdungle93
Copy link
Collaborator

Add pubkey check that it belongs to a whitelisted provider in ZkKYC and AgeCitizenshipKYC.

zwilling
zwilling approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@zwilling zwilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!
I think it would make sense now to delete the Devnet Guardian smart contract. With the EdDSA pubkey check it won't work anymore and we also do not need it anymore because we have the Sample KYC provider websites.

@zwilling zwilling merged commit 1e5b5ca into main Oct 15, 2024
2 checks passed
@zwilling zwilling deleted the add_pubkey_check branch October 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwilling zwilling zwilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhdungle93 @zwilling