Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HashTable algorithm to "Basic". #73

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Change HashTable algorithm to "Basic". #73

merged 1 commit into from
Mar 24, 2020

Conversation

kquick
Copy link
Member

@kquick kquick commented Mar 13, 2020

No description provided.

@kquick
Copy link
Member Author

kquick commented Mar 24, 2020

This addresses a performance regression in various SAW-script tests. Tests that the Cuckoo HashTable implementation could complete in 28 minutes take 88m with the Basic algorithm, but they take 10+ hours with the Linear algorithm.

@kquick kquick merged commit 43cb6d2 into master Mar 24, 2020
@joehendrix
Copy link
Contributor

So that it is captured somewhere, what is the bug that prevents using the Cuckoo implementation?

@kquick
Copy link
Member Author

kquick commented Mar 24, 2020

The issues with the cuckoo implementation were identified by @benjaminselfridge and @travitch ; I will have one of them provide updates here.

@travitch
Copy link
Contributor

@benjaminselfridge noticed some cases where the hash table was not returning values that has been inserted. In our case, it led to getting spurious undefined values out of the table. I suspect that this is the issue: gregorycollins/hashtables#54. That is one of two pretty serious bugs open on the Cuckoo hash table that have been open for almost a year, so our feeling was that a fix is not imminent. I'd love to switch back when we can.

@joehendrix
Copy link
Contributor

Thanks -- that's useful to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants