Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Explicitly specify memory_limiter value #7110

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

k3yss
Copy link
Collaborator

@k3yss k3yss commented Oct 3, 2024

This PR addresses the error "references processor 'memory_limiter' which is not configured". The issue arose from a change in how null values are interpreted for the different property values while using the open telemetry helm charts. Previously, setting it to null would use the default value. However, there was an inconsistency where some queries would be disabled when set to null, while others would use the default value.

To resolve this, the PR explicitly specifies the default value for the memory_limiter property. This approach ensures consistent behavior across all queries and serves as a potential fix for the error.

Reference:
open-telemetry/opentelemetry-helm-charts#1272
open-telemetry/opentelemetry-helm-charts#1275

@krtk6160 krtk6160 merged commit fd5ea63 into GaloyMoney:main Oct 3, 2024
3 of 4 checks passed
@k3yss k3yss deleted the work/keys/otel branch October 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants