Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add postgres as dependency to galoy chart #774

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

krtk6160
Copy link
Member

@krtk6160 krtk6160 commented Mar 31, 2022

It looks like the right way to render nested dependencies is to declare them in the top level chart's dependencies. Without this, helm will silently ignore the nested dependency, which is what we were experiencing on the price chart's testflight.

We can still conditionally render it by using the correct scoping in the condition block.

@krtk6160 krtk6160 merged commit 53fabb5 into main Mar 31, 2022
@krtk6160 krtk6160 deleted the fix_price_subdep branch January 24, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants