-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#118 use serialized key for poly switch #120
Merged
ChrisDufourMB
merged 10 commits into
develop
from
#118-use-serialized-key-for-poly-switch
Feb 25, 2021
Merged
#118 use serialized key for poly switch #120
ChrisDufourMB
merged 10 commits into
develop
from
#118-use-serialized-key-for-poly-switch
Feb 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the untransformed property keys Remove ability to use a PolymorphicSwitch on static properties
Refactor implementation of polymporphic switch
Updates typescript types file Rename "input" to "json" for polymorphic decorator functions
…d-key-for-poly-switch
ChrisDufourMB
added
breaking changes
Issues or fixes with breaking changes
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 8, 2021
hardy925
suggested changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update node tests
3 tasks
…d-key-for-poly-switch
…d-key-for-poly-switch
hardy925
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - 100% test coverage, all passing and our npm build looks good on the latest deno.
Thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking changes
Issues or fixes with breaking changes
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This is a breaking change -
@PolymorphicSwitch
no longer supports static propertiesRefactor the polymorphic switch decorator to use the same key serialization logic as the
@SerializeProperty
decorator.Enhance the polymorphic switch decorator to accept a
test
function, that allows for custom logic when determining if the target property means that the polymorphic type is this class.Fixes #118
Renames
input
argument tojson
for polymorphic decorator functionsThings to look at
README.md
,doc/
,examples/
, etc..)