WIP eat all the delicious ICE #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything fixed now. |
|
Changes look fine. Should we merge this until we can get it all merged? Either way should probably get squashed. (I am excited by whitespace too but not sure everyone who ever uses this library is too :)) |
|
Whoops, messed up the config name. Fixed. Also I guess squashed. This repo was the wild west! Where I could merge whatever I pleased whenever I pleased! So nice. |
|
According to travis all is good, what happened to that TreeSet ICE? |
|
The fix is to use an explicit lifetime as per rust-lang/rust#19982 |
|
Great! This looks good then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just uncovers a different ICE in TreeSet.
Still digging...