-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite, JSON validation and minor bug fixes #40
Conversation
…om Query parameters
…eing passed to provided func
…erent Parameter subclasses
…t was provided (as int has no attribute 'lower')
…unning with the provided List object (instead ran with the children)
…te, datetime.time child types
… fix datetime.* assignment and compress list assertion logic
…str_length and max_str_length tests to 2
… Route parameters
Hey @Ge0rg3! #38 is already closed (was premature) - #39 can be closed, as this includes the changes from there (also, for reference, I'm @d3-steichman, this is just my personal account 😄) |
@d3-steichman @smt5541 looks amazing! If possible please can you add some example to the README for using the jsonschema parsing? Also, it would be great if I can add you as a project maintainer for this, if you'd be interested? This way in future you'd be free to make changes without approval 😄 |
Hey! I can definitely add to the README with a usage example of the JSON Schema, and would be interested in being a maintainer for the project. I'll probably still request review for changes though, just to get another pair of eyes on my code :) |
Great! Should I add you at @smt5541 or at @d3-steichman ? |
Probably @smt5541, as I'm guaranteed to keep access to this account |
Sweet, many thanks, looking forward to collaborating in future 😁 |
This includes the CI changes from #39 (wanted to ensure that the addition of dict support didn't break anything, so I built out the unit tests first) as well as additional code to support JSON Schema validation in dict/list values passed in as Json() parameters and tests to validate this functionality.
Maintainer Edit -- Changes: