Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue UI #1

Merged
merged 15 commits into from
Jan 29, 2022
Merged

Vue UI #1

merged 15 commits into from
Jan 29, 2022

Conversation

jost-s
Copy link
Collaborator

@jost-s jost-s commented Jan 25, 2022

Replaces existing Svelte UI with Vue UI

@bierlingm
Copy link
Collaborator

Looks good to me. @zippy, @artbrock, any further comments / questions?

@jost-s
Copy link
Collaborator Author

jost-s commented Jan 27, 2022

Yeah, it's coming together. I've put together a basic architecture to be expanded upon.

What doesn't work yet is the dynamic passing of the AppWebsocket's port from environment variable to the Vue app. i've submitted a ticket for it and will think of a workaround.

@jost-s
Copy link
Collaborator Author

jost-s commented Jan 29, 2022

  • passing on the App ws port from env var works
  • fixed building for production

Copy link
Collaborator

@harlantwood harlantwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should merge asap so others can build of this in the hackalong.

@harlantwood harlantwood merged commit de149a0 into GeekGene:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants