Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to mentions on profile #110

Merged
merged 11 commits into from
Apr 12, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Apr 2, 2023

Resolves #66

Overview

  • Adds link "Mew Mentions" to agent profile page, pointing to mention tags page for that agent
  • Change mention page route to /mention/:tag/:agentPubKey
  • Fix bug where clicking on profile in profile popup on a mention navigates to profile page, then to mention page
  • Minor refactoring for clarity, simplicity

The styling of the Mention page link doesn't really feel right, but I'm not sure what to use instead.

@mattyg mattyg requested a review from jost-s April 2, 2023 04:17
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create two mews where one mentions user aaa and the other mentions user aaa and user bbb. On aaa's profile I click on "mew mentions" and see both mews. When I click then on bbb, the title changes to "bbb's mew mentions" but there are still both mews where I expect only one to be.

I suppose you need to watch the route.

image

And an unrelated bug:
When I enter "@Someusername" and the popup appears, I hit the down arrow which highlights the first option, but when I press return to confirm, the option isn't selected but instead there's a line feed in the input field
image

@jost-s
Copy link
Collaborator

jost-s commented Apr 5, 2023

Another unrelated problem, in my Launcher window the app doesn't load and I get the SyntaxError: Invalid regular expression: invalid group specifier name

for the URL regex

const RAW_URL_REGEX = /(?:(?<!\^)\b(?:(?:[a-z][\w-]+:(?:\/{1,3}|[a-z0-9%])|[a-z0-9.-]+[.][a-z]{2,4}\/)(?:[^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()[\]{};:'".,<>?«»“”‘’])))/;

@mattyg
Copy link
Collaborator Author

mattyg commented Apr 9, 2023

Another unrelated problem, in my Launcher window the app doesn't load and I get the SyntaxError: Invalid regular expression: invalid group specifier name

thanks I created a new ticket #114

@mattyg
Copy link
Collaborator Author

mattyg commented Apr 9, 2023

When I enter "@Someusername" and the popup appears, I hit the down arrow which highlights the first option, but when I press return to confirm, the option isn't selected but instead there's a line feed in the input field

I can't seem to reproduce this issue @jost-s -- is it still occurring if you pull the latest changes? What browser are you running? Are you pressing the "Enter" key (in main keyboard) or the "Return" key (on numpad).

@mattyg mattyg requested a review from jost-s April 9, 2023 03:28
@mattyg mattyg mentioned this pull request Apr 9, 2023
@jost-s
Copy link
Collaborator

jost-s commented Apr 12, 2023

I can't seem to reproduce this issue @jost-s -- is it still occurring if you pull the latest changes? What browser are you running? Are you pressing the "Enter" key (in main keyboard) or the "Return" key (on numpad).

It only happens in an emergent dialog for, say, creating a mew or replying to one.

@jost-s
Copy link
Collaborator

jost-s commented Apr 12, 2023

A new bug (I don't know when it was introduced):
A profile popup should be shown as long as it's hovered with the mouse. It disappears after a timeout despite hovering.

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumping from one mentions page to another works now

@mattyg
Copy link
Collaborator Author

mattyg commented Apr 12, 2023

A profile popup should be shown as long as it's hovered with the mouse. It disappears after a timeout despite hovering.

fixed

It only happens in an emergent dialog for, say, creating a mew or replying to one.

huh, still can't seem to reproduce it. I think I'm going to merge for now since the other PRs are making changes to the same areas, I'll see if I can reproduce it in those.

@mattyg mattyg merged commit 8d370fd into GeekGene:develop Apr 12, 2023
@mattyg mattyg deleted the feat/link-to-mentions-on-profile branch April 12, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Ability to) view all mentions of an Agent on their profile page
2 participants