-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to mentions on profile #110
Link to mentions on profile #110
Conversation
…clude agentPubKey in params, minotr refactoring for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I create two mews where one mentions user aaa and the other mentions user aaa and user bbb. On aaa's profile I click on "mew mentions" and see both mews. When I click then on bbb, the title changes to "bbb's mew mentions" but there are still both mews where I expect only one to be.
I suppose you need to watch the route.
And an unrelated bug:
When I enter "@Someusername" and the popup appears, I hit the down arrow which highlights the first option, but when I press return to confirm, the option isn't selected but instead there's a line feed in the input field
Another unrelated problem, in my Launcher window the app doesn't load and I get the SyntaxError: Invalid regular expression: invalid group specifier name for the URL regex const RAW_URL_REGEX = /(?:(?<!\^)\b(?:(?:[a-z][\w-]+:(?:\/{1,3}|[a-z0-9%])|[a-z0-9.-]+[.][a-z]{2,4}\/)(?:[^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()[\]{};:'".,<>?«»“”‘’])))/; |
…ute params change
thanks I created a new ticket #114 |
I can't seem to reproduce this issue @jost-s -- is it still occurring if you pull the latest changes? What browser are you running? Are you pressing the "Enter" key (in main keyboard) or the "Return" key (on numpad). |
It only happens in an emergent dialog for, say, creating a mew or replying to one. |
A new bug (I don't know when it was introduced): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping from one mentions page to another works now
fixed
huh, still can't seem to reproduce it. I think I'm going to merge for now since the other PRs are making changes to the same areas, I'll see if I can reproduce it in those. |
Resolves #66
Overview
/mention/:tag/:agentPubKey
The styling of the Mention page link doesn't really feel right, but I'm not sure what to use instead.