Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): persist all data to localStorage #144

Merged
merged 85 commits into from
Jun 16, 2023
Merged

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented May 25, 2023

  • add ui dependency pinia-plugin-persistedstate
  • use localStorage as cache in component SWRV pattern requests
  • use pinia notifications store as cache for notifications SWRV request
  • use localStorage to persist pinia store

@mattyg mattyg marked this pull request as ready for review May 25, 2023 03:54
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toasts at the bottom are only showing for less than a second. I suggest to increase that to 2-3 seconds.

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another likely unrelated issue, when I'm on the feed page (route "/") and refresh the page, I'm rerouted to "/discover".

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing and caching looks good to me.

@mattyg
Copy link
Collaborator Author

mattyg commented May 26, 2023

The toasts at the bottom are only showing for less than a second. I suggest to increase that to 2-3 seconds.

Idk I feel like that's too long for success messages -- maybe just for errors.

@mattyg mattyg mentioned this pull request May 26, 2023
@jost-s
Copy link
Collaborator

jost-s commented May 26, 2023

Idk I feel like that's too long for success messages -- maybe just for errors.

With less than a second you need to be expecting where the message appears and read for your life =D

@mattyg
Copy link
Collaborator Author

mattyg commented May 27, 2023

Idk I feel like that's too long for success messages -- maybe just for errors.

With less than a second you need to be expecting where the message appears and read for your life =D

yeah but the success messages are all 1 word, just confirming success the action you already took (and already know the outcome to). Idk maybe we can get some more feedback and see what people think.

Base automatically changed from feat/notifications-page to develop May 27, 2023 16:46
mattyg added 28 commits June 12, 2023 18:14
…d component to resolve rendering issues in webkitgtk
@mattyg mattyg merged commit 672f148 into develop Jun 16, 2023
@mattyg mattyg deleted the feat/persist-localstorage branch June 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants