Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with multiple chains #207

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix issue with multiple chains #207

merged 1 commit into from
Aug 25, 2023

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Aug 24, 2023

Closes #201

Wasn't able to replicate the bug anymore. Must have been an issue with my session at the time. That being said I've added a unit test to show that we can still recover model estimates when using multiple chains

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/DataJoint.R                      8       0  100.00%
R/DataLongitudinal.R              71       0  100.00%
R/DataSurvival.R                  46       0  100.00%
R/defaults.R                      11       6  45.45%   27, 57-84, 111
R/generics.R                      12       1  91.67%   156
R/JointModel.R                    51       8  84.31%   85-99, 117-120
R/JointModelSamples.R             91       0  100.00%
R/Link.R                           6       0  100.00%
R/LinkGSF.R                       63      12  80.95%   109-120
R/LinkNone.R                       3       1  66.67%   36
R/LinkRandomSlope.R               10       0  100.00%
R/LongitudinalGSF.R               23       0  100.00%
R/LongitudinalModel.R             10       0  100.00%
R/LongitudinalRandomSlope.R       17       1  94.12%   43
R/LongitudinalSamples.R           15       0  100.00%
R/Parameter.R                     12       0  100.00%
R/ParameterList.R                 28       0  100.00%
R/Prior.R                         58       9  84.48%   127-135
R/simulations_gsf.R               43       0  100.00%
R/simulations_os.R                11       5  54.55%   35-39
R/simulations_rs.R                21       0  100.00%
R/simulations.R                   99       1  98.99%   122
R/StanModel.R                      7       0  100.00%
R/StanModule.R                   145       5  96.55%   186-187, 203, 236, 247
R/SurvivalExponential.R            9       0  100.00%
R/SurvivalLoglogistic.R           10      10  0.00%    31-40
R/SurvivalModel.R                 12       0  100.00%
R/SurvivalSamples.R               43       0  100.00%
R/SurvivalWeibullPH.R             10       0  100.00%
R/utilities.R                    116       1  99.14%   13
R/zzz.R                           10      10  0.00%    4-16
TOTAL                           1071      70  93.46%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 603e814

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    23 suites   4m 40s ⏱️
  59 tests   59 ✔️ 0 💤 0
215 runs  215 ✔️ 0 💤 0

Results for commit daa1ccc.

@gowerc gowerc merged commit 5bb627a into main Aug 25, 2023
18 checks passed
@gowerc gowerc deleted the fix/multiple_chains_bug branch August 25, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running multiple chains results in wildly incorrect estimates
2 participants