-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print methods #235
Print methods #235
Conversation
Removing reviewer request and converting back to draft, the other print methods are highly dependent on the parameters so will do them together |
Code Coverage Summary
Diff against main
Results for commit: c5a2eeb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Ok @danielinteractive this should be ready for review now. Due to their interconnected nature this implements the print methods for
I would recommend reviewing this by just reviewing the _snaps/*.md files which outline clearly what is displayed when each of these objects is printed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @gowerc ! Great work
Partially addresses #197
As a slightly annoying aside apparently
print.<class>
does not work for S4 objects so I had to break with the S3 method convention and define a show method in order for it to work.