-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GridEven and GridManual #303
Conversation
Code Coverage Summary
Diff against main
Results for commit: 18684dc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 41 suites 7m 28s ⏱️ Results for commit d7ebf0a. |
Unit Test Performance Difference
Additional test case details
Results for commit 67ca860 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gowerc , looks good, see one suggestion below
Closes #302
Added
GridManual
to allow for very fine tuned control and thenGridEven
which directly addresses #302 . These should help improve the UI when generating the required quantity plots.EDIT
Sorry as a minor aside I rename
pt_to_ind
tosubject_to_index
to both be consistent and more expressive