-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle for Graph Snapshot Testing #361
Conversation
Code Coverage Summary
Diff against main
Results for commit: a36dbdc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 140 suites 7m 54s ⏱️ Results for commit a36dbdc. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 14a09bd ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion. Maybe you already considered it? @gowerc
No corresponding issue.
Unit tests were failing on internal CICD build due to snapshot discrepancies, as far as I can tell this is minor white space stuff on graphs due to differences in package versions (I've posted the diff below). To address this I've added a toggle for graph snapshots which is enabled for the GitHub CICD but disabled for the in house builds.
I opted for a wrapper around the
expect*
function rather than skipping the test as this way it will still through an error on the internal build if the plot generation code fails its only the final comparison that is suppressed.