Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prior_shrinkage documentation #378

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix prior_shrinkage documentation #378

merged 2 commits into from
Jul 9, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Jul 4, 2024

Closes #377

written formula in the documentation was wrong, this fixes that

Copy link
Contributor

github-actions bot commented Jul 4, 2024

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          34       4  88.24%   52, 396, 416, 471
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       126      10  92.06%   146-151, 201, 205, 247, 293, 299
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     13       3  76.92%   59, 76, 91
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           88       6  93.18%   164-168, 183
R/LongitudinalGSF.R                   89       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             80       5  93.75%   155-159
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            254       6  97.64%   507, 651-665
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        52       0  100.00%
R/SimLongitudinalGSF.R                60       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          50       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               3009     120  96.01%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3d78ae9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Unit Tests Summary

    1 files    160 suites   6m 20s ⏱️
  139 tests   136 ✅ 3 💤 0 ❌
1 051 runs  1 047 ✅ 4 💤 0 ❌

Results for commit 3d78ae9.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
compile 💚 $6.51$ $-1.05$ $0$ $0$ $0$ $0$
extract_quantities 💚 $4.21$ $-4.16$ $0$ $0$ $0$ $0$
misc_models 💔 $6.04$ $+3.54$ $0$ $0$ $0$ $0$
model_multi_chain 💔 $2.18$ $+25.59$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $50.01$ $-1.39$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $116.97$ $+2.56$ GridPrediction_works_as_expected_for_Survival_models
LongitudinalQuantiles 💔 $6.66$ $+1.59$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $9.64$ $-4.39$ Print_method_for_LongitudinalRandomSlope_works_as_expected
SurvivalExponential 💔 $21.79$ $+1.13$ SurvivalExponential_can_recover_true_parameter_including_covariates_
SurvivalLoglogistic 💔 $13.99$ $+5.29$ sim_os_loglogistic_is_consistant_with_flexsurv
compile 💚 $6.51$ $-1.05$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
extract_quantities 💚 $4.21$ $-4.16$ extract_quantities_works_as_expected
misc_models 💔 $6.04$ $+3.54$ Longitudinal_Model_doesn_t_print_sampler_rejection_messages
model_multi_chain 💔 $2.18$ $+25.59$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains
stan_functions 💚 $27.47$ $-27.03$ GSF_SLD_function_works_as_expected

Results for commit 65e13b1

♻️ This comment has been updated with latest results.

@gowerc gowerc merged commit 1766062 into main Jul 9, 2024
9 of 17 checks passed
@gowerc gowerc deleted the 377-fix-shrinkage-docs branch July 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option description for prior_shrinkage doesn't match the given formula
2 participants