-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust auto frame interval for themes #4991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but just checking/letting you know that the main reason that scale increased to 1.75 had to do with annotations in modern changing from 37 to 37N etc. However, I do think there was more, hm, gut/guess involved than science in picking that factor. It looked OK for some examples I looked at but clearing here we are because of it. Looks like you checked lots of examples so I am happy with that.
Yes, I appreciated that there were comments in the code explaining that decision. In the PostScript files that needed updating with this change, I found that there were more that went from an insufficient number of annotations to a reasonable number than there were going from a good distance between annotation text to a bad distance. You are right, it's subjective. edit: to clarify, I didn't think any of the annotations became problematically close, although I would select greater spacing for plots with custom -B axes settings. If you didn't see, PyGMT just implemented a separate 'data version control' for their test images. Maybe if that works well we can use it and then update the frame selections as much as we need without the downsides related to repo size - GenericMappingTools/pygmt#1036. |
We should discuss doing the same for GMT. If I understand correctly it would limit the inclusion of large files into the GMT repo. |
Agreed. It will be good to see how it goes for PyGMT before putting effort into migrating the baseline images. So, we could discuss at the community meeting or in a GitHub issue around that time. |
Description of proposed changes
This PR relaxes the increase in annotation/frame/grid intervals from the gmt themes branch to minimize the instances in which 1 or fewer annotations are plotted on an axis.
For example:
gmt basemap -JM6c -R-125/-121/47/48 -B -png map
Before:
After:
Fixes #4955
Reminders