Long-lasting bug with seniority finally killed in gmt_crossover function #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHen we use -G to create creat circle lines and wish to annotate the contours where those two line-types intersect we did this: 1. Create the helper lines in geographic coordinates then convert to plot coordinates 2. COnert contour lines to plot coordinates. 3. Call gmt_crossover with geo = true; Hence, gmt_crossover would look for periodic data and jump even though there is none in the Caresian x,y. This PR passes false instead of GMT_M_is_lon (GMT, GMT_IN) since that is not correct. No change to any tests, but is homing in on the missing label (for macOS only?) in greenspline_5.sh test.
Update PS file
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified images
Report last updated at commit 41a3558 |
seisman
approved these changes
Dec 12, 2023
|
Nice to see a senior bug bite the dust. Well done! -W
… On Dec 12, 2023, at 11:30 AM, Paul Wessel ***@***.***> wrote:
Merged #8188 <#8188> into master.
—
Reply to this email directly, view it on GitHub <#8188 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APUT6GJXHD4RD2HDIEMHV4TYJCBD5AVCNFSM6AAAAABARV2DXCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGIZDMMBZGAYTKNY>.
You are receiving this because your review was requested.
|
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
spline_5.shhas failed (at least on macOS) for the longest time. Finally decided to debug the sucker and found that the missing contour annotations had to do with round-off. If fact there were two missing but only one was seen as a bug. Problem was that if the crossing was exactly on a data noted then our test to see if it was outside the segment failed because we checked along-track "time":tx_a < ta_stop && tx_b < tb_stopClearly, if tx_a or tx_b equal ta_stop or tb_stop then we still fail (cutting at the mode). Solution is to allow one of the ends to be equal:
if (tx_a < ta_stop && tx_b <= tb_stop)Now, the contour map places all the contours crossing the imaginary line set by -Gl:
The topmost 40 label in the bottom plot was missing before, but so was the 30 contour. Now all is well. A bug with seniority bites the dust!