Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude .dvc and .dvcignore from source package #1095

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Exclude .dvc and .dvcignore from source package #1095

merged 1 commit into from
Mar 28, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 21, 2021 •
edited
Loading

Description of proposed changes

Following directories/files are excluded from the source distributions:

  • .dvc/*
  • .dcvignore

Fixes #1086

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Mar 21, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 21, 2021
@seisman seisman requested review from weiji14 and removed request for weiji14 March 21, 2021 23:50
@seisman

This comment has been minimized.

Sign in to view
@seisman seisman mentioned this pull request Mar 27, 2021
Closed
@seisman seisman changed the title Exclude dvc files and baseline images from source package Exclude .dvc and .dvcignore from source package Mar 27, 2021
@seisman seisman marked this pull request as ready for review March 27, 2021 21:15
@seisman seisman merged commit dacef52 into master Mar 28, 2021
@seisman seisman deleted the exclude-dvc branch March 28, 2021 14:10
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Apr 8, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Exclude .dvc and .dvcignore from source package (GenericMappingTools#…
3ce6d26 
…1095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

@seisman seisman

@weiji14 weiji14

Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Exclude dvc related files from source distribution
2 participants
@seisman @weiji14