Migrate Figure.coast tests to dvc

[willschlitzer]

Changing the tests in test_coast.py to use dvc and mpl_image_compare. An update/fix to #1102.

Related to #1131.

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[seisman]

The coast wrapper is very simple and only has a few lines of codes.

As documented in the contributing guides,

The highest priority for tests should be the Python-specific code, such as numpy, pandas, and xarray objects and the virtualfile mechanism.

I feel some of the tests are unnecessary. Tests for a global map, a regional map, a map using dcw should be enough.

Edit: IMHO, only the following tests are needed:

• test_coast_iceland
• test_coast_world_mercator
• test_coast_required_args
• test_coast_dcw_single
• test_coast_dcw_list

[willschlitzer]

The coast wrapper is very simple and only has a few lines of codes.

As documented in the contributing guides,

The highest priority for tests should be the Python-specific code, such as numpy, pandas, and xarray objects and the virtualfile mechanism.

I feel some of the tests are unnecessary. Tests for a global map, a regional map, a map using dcw should be enough.

Edit: IMHO, only the following tests are needed:

• test_coast_iceland

• test_coast_world_mercator

• test_coast_required_args

• test_coast_dcw_single

• test_coast_dcw_list

Sounds good! I'll shorten it down.

[willschlitzer]

@seisman @weiji14 I removed the tests that we deemed not needed and deleted the .dvc files; do I have to do anything else to fully remove these tests?

[github-actions]

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status	Path
added	pygmt/tests/baseline/test_coast_dcw_list.png
added	pygmt/tests/baseline/test_coast_dcw_single.png
added	pygmt/tests/baseline/test_coast_region.png
added	pygmt/tests/baseline/test_coast_world_mercator.png

Image diff(s)

• pygmt/tests/baseline/test_coast_dcw_list.png

• pygmt/tests/baseline/test_coast_dcw_single.png

• pygmt/tests/baseline/test_coast_region.png

• pygmt/tests/baseline/test_coast_world_mercator.png

Report last updated at commit 82cd7f0