Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test_figure_shift_origin to dvc #1133

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Migrate test_figure_shift_origin to dvc #1133

merged 3 commits into from
Mar 30, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 27, 2021

Description of proposed changes

  • Remove the old baseline image test_shift_origin.png from git
  • Rename the test from test_shift_orign to test_figure_shift_origin so the name is consistent with other tests
  • Simplify the tests (using SI units, passing list to regions, only plotting frames and focus on testing xshift and yshift.

Address #1131.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 27, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 27, 2021
@seisman seisman self-assigned this Mar 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_figure_shift_origin.png

Image diff(s)

  • pygmt/tests/baseline/test_figure_shift_origin.png

Report last updated at commit c7963ec

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Mar 30, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@seisman seisman merged commit 6ef9512 into master Mar 30, 2021
@seisman seisman deleted the test-shift_origin branch March 30, 2021 18:01
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants