Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pygmt.grd2cpt tests to use dvc #1162

Merged
merged 5 commits into from
Apr 2, 2021
Merged

Migrate pygmt.grd2cpt tests to use dvc #1162

merged 5 commits into from
Apr 2, 2021

Conversation

willschlitzer
Copy link
Contributor

As discussed in #1131, this moves the reference figures in fig.grd2cpt to use dvc and replaces the tests using @check_figures_equal.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 2, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone Apr 2, 2021
@willschlitzer willschlitzer self-assigned this Apr 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_grd2cpt.png

Image diff(s)

  • pygmt/tests/baseline/test_grd2cpt.png

Report last updated at commit 078c729

@willschlitzer willschlitzer marked this pull request as ready for review April 2, 2021 11:47
@willschlitzer willschlitzer changed the title WIP: Migrate fig.grd2cpt tests to use dvc Migrate fig.grd2cpt tests to use dvc Apr 2, 2021
pygmt/tests/test_grd2cpt.py Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented Apr 2, 2021

/format

@seisman seisman changed the title Migrate fig.grd2cpt tests to use dvc Migrate pygmt.grd2cpt tests to use dvc Apr 2, 2021
@seisman seisman merged commit e96fa47 into master Apr 2, 2021
@seisman seisman deleted the test-grd2cpt-dvc branch April 2, 2021 19:03
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants