Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Figure.subplot tests to dvc #1170

Merged
merged 5 commits into from
Apr 3, 2021
Merged

Migrate Figure.subplot tests to dvc #1170

merged 5 commits into from
Apr 3, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Related to #1131.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 3, 2021
@michaelgrund michaelgrund added this to the 0.4.0 milestone Apr 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_subplot_autolabel_margins_title.png
added pygmt/tests/baseline/test_subplot_basic_frame.png
added pygmt/tests/baseline/test_subplot_clearance_and_shared_xy_axis_layout.png
added pygmt/tests/baseline/test_subplot_direct.png

Image diff(s)

  • pygmt/tests/baseline/test_subplot_autolabel_margins_title.png

  • pygmt/tests/baseline/test_subplot_basic_frame.png

  • pygmt/tests/baseline/test_subplot_clearance_and_shared_xy_axis_layout.png

  • pygmt/tests/baseline/test_subplot_direct.png

Report last updated at commit 7513b6c

pygmt/tests/test_subplot.py Outdated Show resolved Hide resolved
pygmt/tests/test_subplot.py Outdated Show resolved Hide resolved
@weiji14
Copy link
Member

weiji14 commented Apr 3, 2021

Btw, we should teach you about making batch changes to save on a few clicks. See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes. You can go to the 'Files' tab on the GitHub UI and click on 'Add suggestion to batch'.

image

@michaelgrund
Copy link
Member Author

Btw, we should teach you about making batch changes to save on a few clicks. See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes. You can go to the 'Files' tab on the GitHub UI and click on 'Add suggestion to batch'.

image

Thanks for mentioning @weiji14, didn't know that so far 😄.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @michaelgrund, feel free to merge this in yourself. I've disabled the 'Docs' CI test requirement (since they don't run on changes to `pygmt/tests/*') so you should be able to merge it in straight this time.

@michaelgrund michaelgrund merged commit c75a2ed into master Apr 3, 2021
@michaelgrund michaelgrund deleted the test-subplot-dvc branch April 3, 2021 10:57
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants