Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap sphinterpolate #1418

Merged
merged 24 commits into from
Sep 27, 2021
Merged

Wrap sphinterpolate #1418

merged 24 commits into from
Sep 27, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Aug 7, 2021

This pull request wraps the module sphinterpolate.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Aug 7, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Aug 7, 2021
@willschlitzer willschlitzer self-assigned this Aug 7, 2021
@willschlitzer willschlitzer mentioned this pull request Aug 9, 2021
5 tasks
@willschlitzer willschlitzer changed the title WIP: Wrap sphinterpolate Wrap sphinterpolate Aug 11, 2021
@willschlitzer willschlitzer marked this pull request as ready for review August 11, 2021 08:55
pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/src/sphinterpolate.py Show resolved Hide resolved
pygmt/tests/test_sphinterpolate.py Outdated Show resolved Hide resolved
@willschlitzer
Copy link
Contributor Author

I would prefer to have #1420 merged before this PR so that these tests can import the Mars data in a Python format.

pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/__init__.py Outdated Show resolved Hide resolved
pygmt/src/__init__.py Outdated Show resolved Hide resolved
pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/src/sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/tests/test_sphinterpolate.py Outdated Show resolved Hide resolved
pygmt/tests/test_sphinterpolate.py Outdated Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me 🚀

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Sep 25, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except a suggestion on the docstrings.

V="verbose",
)
@kwargs_to_strings(I="sequence", R="sequence")
def sphinterpolate(data, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to support x, y, z input following #1479, but can be done in a separate PR.

@weiji14 weiji14 merged commit 0926206 into main Sep 27, 2021
@weiji14 weiji14 deleted the wrap-sphinterpolate branch September 27, 2021 21:47
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Sep 27, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Wrapping the sphinterpolate function which creates spherical
grid files in tension of data. Official GMT documentation is at 
https://docs.generic-mapping-tools.org/6.2/sphdistance.html.
Aliased outgrid (G), spacing (I), region (R), verbose (V).

Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants