-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap sphinterpolate #1418
Wrap sphinterpolate #1418
Conversation
Co-authored-by: Wei Ji <[email protected]>
I would prefer to have #1420 merged before this PR so that these tests can import the Mars data in a Python format. |
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me 🚀
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except a suggestion on the docstrings.
Co-authored-by: Dongdong Tian <[email protected]>
V="verbose", | ||
) | ||
@kwargs_to_strings(I="sequence", R="sequence") | ||
def sphinterpolate(data, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to support x, y, z
input following #1479, but can be done in a separate PR.
Co-authored-by: Wei Ji <[email protected]>
Wrapping the sphinterpolate function which creates spherical grid files in tension of data. Official GMT documentation is at https://docs.generic-mapping-tools.org/6.2/sphdistance.html. Aliased outgrid (G), spacing (I), region (R), verbose (V). Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]>
This pull request wraps the module
sphinterpolate
.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version