-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing aliases to pygmt.xyz2grd #1506
Conversation
Please change:
to
|
changed |
I think xyz2grd should go under "operations on tabular data" rather than "operations on grids" in |
Co-authored-by: Meghan Jones <[email protected]>
changed in fda29eb |
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just three suggestions - two for adding missing lower-case common options and one for referring to an alias rather than short option.
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
When I run |
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to add alias for projection -J
, but still missing aliases for -D
/-S
/-Z
from https://docs.generic-mapping-tools.org/6.2/xyz2grd. If you're not adding those 3 (which is fine if you're in a rush to get this merged before v0.5.0), then please edit the first post to change "Fixes #1424" to "Addresses #1424".
Co-authored-by: Wei Ji <[email protected]>
Add missing aliases duplicate (A), projection (J), convention (Z), binary (b), nodata (d), find (e), coltypes (f), header (h), incols (i), registration (r), and wrap (w) to pygmt.xyz2grd. Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Wei Ji <[email protected]>
This pull request adds missing aliases for
xyz2grd
.Continuation of #635 and #636. Addresses #1424.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version