WIP: Separate grdhisteq into equalize_grid and compute_bins #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wei Ji <[email protected]>
* Update plot.py * add decorator * adjust test_plot_datetime * adjust gallery examples
* Update plot3d.py * adjust tests
…1554) See https://docs.generic-mapping-tools.org/6.2/gmtwhich#g. Co-authored-by: Michael Grund <[email protected]>
Adding tomli to fix the GitHub Actions CI test breakages reported in #1392. This is a temporary measure until `pytest-cov>2.12.1` is released. * Remove coverage dependency since it is required by pytest-cov already
The alias of d is nodata in other modules, but was incorrectly set to data in blockmean and blockmode. This PR fixes the problem. blockmode was wrapped in #1456 (after v0.4.1), blockmean was wrapped in #1092 but the wrong alias was added in #1500 (after v0.4.1). Thus, the change won't go into the deprecation cycle.
…ng (#1530) * Raise a warning intsead an exception for irregular grid spacing * Calcuate grid spacing if irregular spacing is detected * Update pygmt/tests/test_clib.py Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Wei Ji <[email protected]>
maxrjones
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR modifies #1433 by splitting the grdhisteq module into two functions, compute_bins and equalize_grid which output tabular or gridded data respectively.
Note that the target branch for the PR is grdhisteq, not main. I opened this as a separate PR from #1433 to facilitate discussion about the API for modules that can output grids or tables.
Relates to #1536
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version