-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase minimum thumbnail height in style.css to fit text #1575
Conversation
doc/_static/style.css
Outdated
@@ -209,6 +209,11 @@ a.copybtn { | |||
text-align: center!important; | |||
} | |||
|
|||
.sphx-glr-thumbcontainer { | |||
min-height: 240px !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone have any ideas for what might be going on with the vercel build failure? |
Appears to be a problem with |
Ah, thanks. What do you think about pinning setuptools and pip until the issue is closed? I would prefer this to prevent people from having difficulties with their local dev environments. |
I think the |
OK. I actually do not even know how this change looks, since I ran into the same problem. I will simply wait before working more on the PRs. |
@weiji14, was this an accidental close? |
Oops, sorry. I've reopened the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'd prefer to get this right now, but do not want to commit any changes after approval without discussion first. Widening the thumbnails wouldn't affect the distance between the image and the border since they are scaled. We could instead add a padding to the image:
Also, if you think there's too much whitespace around the text we could adjust the width in addition to the height instead of just the height to accommodate the text description:
|
I like the second option (adjust both the width of the thumbnail image and the text below it). Since the text doesn't wrap to newlines so much, we could even keep the height at 240px (which is what you did I think?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…ppingTools#1575) * Increase min thumbnail height to fit text * Add max-width for image and min-width for container Co-authored-by: Wei Ji <[email protected]>
Description of proposed changes
Sphinx-gallery updated the default thumbnail size in v0.9.0, such that the text does not fit in our boxes in the devdocs gallery. This PR increases the height slightly for the gallery and the team page so the text fits.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version