Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 #1591

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Support Python 3.10 #1591

merged 4 commits into from
Oct 28, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 27, 2021

Description of proposed changes

Python 3.10 has been released on 7 October 2021, changelog is at https://docs.python.org/3.10/whatsnew/3.10.html. See previous PR for Python 3.9 at #689.

This PR is part 1/2 for adding Python 3.10 support to PyGMT, see also the sister PR at #1577 which will update the ci_test.yaml and ci_tests_dev.yaml continuous integration tests.

Note that this PR updates the publish-to-pypi.yml and style-checks.yml GitHub Actions workflows have been updated to use Python 3.10 in this PR. These two work because it uses the setup-python instead of setup-miniconda.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Oct 27, 2021
@weiji14 weiji14 added this to the 0.5.0 milestone Oct 27, 2021
@weiji14 weiji14 self-assigned this Oct 27, 2021
@weiji14
Copy link
Member Author

weiji14 commented Oct 27, 2021

Ok, I've checked that make package (building the PyGMT source and wheel distribution) works on Python 3.10 via the publish-to-pypi.yml workflow (see https://github.com/GenericMappingTools/pygmt/runs/4028836891?check_suite_focus=true#step:7:1275), so people using Python 3.10 should be able to install PyGMT from PyPI 🤞

@weiji14 weiji14 marked this pull request as ready for review October 28, 2021 00:18
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Oct 28, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 28, 2021
@seisman seisman merged commit 4035cbe into main Oct 28, 2021
@seisman seisman deleted the python-3.10 branch October 28, 2021 09:17
@seisman seisman mentioned this pull request Oct 26, 2022
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
* Add Python 3.10 classifier to setup.py. Also changed PyGMT's development status from alpha
to beta.
* Use Python 3.10 for style_checks and publish-to-pypi CI workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants