-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend Figure.timestamp and remove timestamp (U) alias from all plotting methods #2135
Conversation
The warning message looks like this: >>> import pygmt
>>> fig = pygmt.Figure()
>>> fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, U=True)
<ipython-input-3-47b2c09a10fd>:1: SyntaxWarning: Parameter 'U' and 'timestamp' is deprecated since v0.8.0. Use Figure.timestamp() instead.
fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, U=True)
>>> fig.show()
>>> import pygmt
>>> fig = pygmt.Figure()
>>> fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, timestamp=True)
<ipython-input-7-eff609310ed5>:1: SyntaxWarning: Parameter 'U' and 'timestamp' is deprecated since v0.8.0. Use Figure.timestamp() instead.
fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, timestamp=True)
>>> fig.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: Figure.timestamp is not implemented yet.
Will definitely need to implement this before this PR can be approved 🙂
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description of proposed changes
Similar to #2071.
The purpose of this PR is to remove timestamp (U) alias and recommend use
Figure.timestamp
instead.NOTE:
Figure.timestamp
is not implemented yet.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version