Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.psconvert: Remove the deprecated parameter 'icc_gray' (deprecated since v0.6.0) #2267

Merged
merged 4 commits into from
Dec 23, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 22, 2022

Description of proposed changes

Related to #1673.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Dec 22, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 22, 2022
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 22, 2022
65 tasks
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 22, 2022
@seisman seisman merged commit de638db into main Dec 23, 2022
@seisman seisman deleted the remove-icc_gray branch December 23, 2022 11:17
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants